• Clemens Backes's avatar
    [wasm] Remove a long-living CodeSpaceWriteScope · a8609e06
    Clemens Backes authored
    The {CodeSpaceWriteScope} in {InstanceBuilder::Build} was kept open
    while processing imports, which could compile another wasm module via
    {compiler::ResolveWasmImportCall} and
    {WasmEngine::SyncCompileTranslatedAsmJs}. This leads to errors since
    {CodeSpaceWriteScope}s for different modules cannot be held open at the
    same time.
    
    This CL fixes that by only opening the {CodeSpaceWriteScope} for the
    actual compilation of import wrappers.
    
    Drive-by: Only call {ProcessImports} if there are imports to be
    processed, to avoid some of the overhead of {ProcessImports} and
    {CompileImportWrappers}.
    
    R=jkummerow@chromium.org
    
    Bug: chromium:1239522
    Change-Id: Ifbaf64a4be92088ae4a3fd7e9700a33397b2a967
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097283
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76311}
    a8609e06
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...