• Minoru Chikamune's avatar
    Revert "Reland: [wasm] Check correctness of thread-local write protection" · 996e0380
    Minoru Chikamune authored
    This reverts commit 1c0cca0f.
    
    Reason for revert: this made tree closed. (https://crbug.com/1238174)
    
    Original change's description:
    > Reland: [wasm] Check correctness of thread-local write protection
    >
    > The fix landed as a separate CL: https://crrev.com/c/3081522
    > This is an unmodified reland.
    >
    > Original description:
    > We make an undocumented assumption in {CodeSpaceWriteScope} that a
    > single thread will only work on one module at a time. If this is
    > violated, the thread-local {code_space_write_nesting_level_} would
    > prevent the second module from being switched to writable.
    >
    > This CL adds a second thread local (in debug only) to check that if
    > there is already a {CodeSpaceWriteScope} open that it contains the same
    > {NativeModule} as any nested scope.
    >
    > R=​jkummerow@chromium.org
    >
    > Bug: v8:11974
    > Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
    > Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
    > Change-Id: Id827b6ca472f695e4500584349aba159aa07eed1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3080578
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76177}
    
    Bug: v8:11974, 1238174
    Change-Id: I74d8723344e4b9015d956ebfe3fda492280356b6
    Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3084041
    Auto-Submit: Minoru Chikamune <chikamune@google.com>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#76184}
    996e0380
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...