• Minoru Chikamune's avatar
    Revert "Reland: [wasm] Check correctness of thread-local write protection" · 996e0380
    Minoru Chikamune authored
    This reverts commit 1c0cca0f.
    
    Reason for revert: this made tree closed. (https://crbug.com/1238174)
    
    Original change's description:
    > Reland: [wasm] Check correctness of thread-local write protection
    >
    > The fix landed as a separate CL: https://crrev.com/c/3081522
    > This is an unmodified reland.
    >
    > Original description:
    > We make an undocumented assumption in {CodeSpaceWriteScope} that a
    > single thread will only work on one module at a time. If this is
    > violated, the thread-local {code_space_write_nesting_level_} would
    > prevent the second module from being switched to writable.
    >
    > This CL adds a second thread local (in debug only) to check that if
    > there is already a {CodeSpaceWriteScope} open that it contains the same
    > {NativeModule} as any nested scope.
    >
    > R=​jkummerow@chromium.org
    >
    > Bug: v8:11974
    > Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
    > Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
    > Change-Id: Id827b6ca472f695e4500584349aba159aa07eed1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3080578
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76177}
    
    Bug: v8:11974, 1238174
    Change-Id: I74d8723344e4b9015d956ebfe3fda492280356b6
    Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3084041
    Auto-Submit: Minoru Chikamune <chikamune@google.com>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#76184}
    996e0380
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...