• Benedikt Meurer's avatar
    [debug][wasm] Store debug proxy maps on native context. · 975ded1d
    Benedikt Meurer authored
    This was originally proposed by yangguo@ on the original CL that
    introduced this, but back then it looked easier to put the map cache
    onto the global object than on the native context. However it turns out
    that this is indeed quite strange and also not necessarily supported (we
    got crashes from the wild indicating that the `Object::GetProperty()`
    might fail on the global object). So this CL simplifies the original
    design and just puts the map cache onto the native context like with do
    with other context specific maps.
    
    Fixed: chromium:1167399
    Bug: chromium:1127914, chromium:1159402, chromium:1071432, chromium:1164241
    Change-Id: Ie16f892dd19b55b4c49e9d4829cab3c24ae64ad3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2637226
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72159}
    975ded1d
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...