• Clemens Backes's avatar
    Revert "[compiler] Emit a function-entry stack check on OSR-entry" · 3ad23424
    Clemens Backes authored
    This reverts commit 8703c38d.
    
    Reason for revert: New test is timing out on gc-stress (e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/31726/overview)
    
    Original change's description:
    > [compiler] Emit a function-entry stack check on OSR-entry
    >
    > This CL extends the smarter function-entry stack check logic (see
    > v8:9534) to OSR'd code. These smarter stack checks prevent
    > overflowing the stack during deoptimization.
    >
    > The challenge for both function-entry (FE) and OSR-entry (OE) stack
    > checks is that there is no dedicated physical StackCheck to
    > deoptimize into. For more context: the physical StackCheck bytecode
    > was removed in crrev.com/c/1914218.
    >
    > FE stack checks solve this by using a marker bailout id to signify
    > a deopt bytecode offset before the first bytecode.
    >
    > In this CL, OE stack checks take a similar approach by using the
    > OSR'd loop's JumpLoop bytecode, which is conceptually immediately
    > before the OSR'd loop header.
    >
    > When a stack overflow at an OE stack check occurs: %StackGuard
    > may cause a lazy deopt on return to the optimized OSR code,
    > causing re-execution of the JumpLoop handler in the
    > InterpreterEnterBytecodeAdvance builtin, ultimately continuing
    > execution the interpreter at the first bytecode of the OSR'd loop
    > header.
    >
    > Bug: chromium:1034322, v8:9534
    > Change-Id: I1ae88a08702cde9a5eb84a451a9f1acc41204d5c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625872
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72153}
    
    TBR=neis@chromium.org,jgruber@chromium.org,solanes@chromium.org
    
    Change-Id: Ie72f2e2927ffa83d595aad0d88c606d422f953a2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1034322
    Bug: v8:9534
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2637858Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72158}
    3ad23424
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...