• Frank Tang's avatar
    [Intl] Remove incorrect CHECK · 93cbb579
    Frank Tang authored
    The CHECK was introduced in d7ae63e6.
    
    The first time the property got read by ToDateTimeOptions
    and the test will cause the needsDefault in ToDateTimeOptions
    be false. Then in step 22 of InitializeDateTimeFormat,
    it will get all undefined and cause the
    skeleton to be empty string. If we only pass in empty options, the
    defaults will be filled by ToDateTimeOptions and won't cause any
    CHECK failure.
    
    
    Bug: chromium:888299
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: I3ee14434f0708eaaea78cc8857591152d1bdef8a
    Reviewed-on: https://chromium-review.googlesource.com/1241316
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56226}
    93cbb579
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...