• Frank Tang's avatar
    [Intl] Remove incorrect CHECK · 93cbb579
    Frank Tang authored
    The CHECK was introduced in d7ae63e6.
    
    The first time the property got read by ToDateTimeOptions
    and the test will cause the needsDefault in ToDateTimeOptions
    be false. Then in step 22 of InitializeDateTimeFormat,
    it will get all undefined and cause the
    skeleton to be empty string. If we only pass in empty options, the
    defaults will be filled by ToDateTimeOptions and won't cause any
    CHECK failure.
    
    
    Bug: chromium:888299
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: I3ee14434f0708eaaea78cc8857591152d1bdef8a
    Reviewed-on: https://chromium-review.googlesource.com/1241316
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56226}
    93cbb579
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...