-
Michael Achenbach authored
This reverts commit 2b94e567. Reason for revert: Speculative based on layout test failures on win and mac which could block the roll: https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Win/5294 https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Mac/4955 Original change's description: > [inspector] Report [[Prototype]] as internal property. > > Previously the inspector was trying to add a special `__proto__` > property to every JSObject, which looked and behaved like a real > data property on the object. But this is confusing to developers > since `__proto__` is not a real data property, but usually an > accessor property on the `Object.prototype`. > > Additionally all other internal properties are reported using the > [[Name]] notation, with the [[Prototype]] having been the strange > outlier. > > Drive-by-cleanup: Use an ArrayList to collect the name/value pairs > inside Runtime::GetInternalProperties(), which makes this function > more readable and easier to add things. > > Bug: chromuium:1162229 > Fixed: chromium:1197019 > Screenshot: https://imgur.com/a/b7TZ32s.png > Change-Id: Ic4c1e35e2e65f90619fcc12bf3a72806cadb0794 > Doc: http://doc/1Xetnc9s6r0yy4LnPbqeCwsnsOtBlvJsV4OCdXMZ1wCM > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814565 > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73881} Bug: chromuium:1162229 Change-Id: Ia893ad672eb370fa6fce7eddf2947bf8f6755831 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2818386 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73886}
0e2d3413
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
bugs/harmony | ||
debug | ||
protocol | ||
regress | ||
wrapper | ||
BUILD.gn | ||
OWNERS | ||
debugger.status | ||
test-api.js | ||
testcfg.py |