• Simon Zünd's avatar
    [torque] "OneOf" parser rule returns Identifier* instead of std::string · 7626fe35
    Simon Zünd authored
    To obtain SourcePositions for unary and binary operators, this CL
    changes the "OneOf" parser rule to produce an Identifier*. Forwarding
    this new identifier as callee for a CallExpression enables
    "goto Definition" support for operators in the Language Server.
    
    Side note: VSCode won't highlight operators with an underlined font
    when hovering with Ctrl pressed. "goto Definition" will work
    nonetheless using default F12 or Ctrl-Click.
    
    R=tebbi@chromium.org
    
    Bug: v8:7793
    Change-Id: Iada06009e324a3de8c453ec058427049e921a70d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598690
    Auto-Submit: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61263}
    7626fe35
Name
Last commit
Last update
..
ls Loading commit data...
ast.h Loading commit data...
cfg.cc Loading commit data...
cfg.h Loading commit data...
contextual.h Loading commit data...
csa-generator.cc Loading commit data...
csa-generator.h Loading commit data...
declarable.cc Loading commit data...
declarable.h Loading commit data...
declaration-visitor.cc Loading commit data...
declaration-visitor.h Loading commit data...
declarations.cc Loading commit data...
declarations.h Loading commit data...
earley-parser.cc Loading commit data...
earley-parser.h Loading commit data...
file-visitor.cc Loading commit data...
file-visitor.h Loading commit data...
global-context.h Loading commit data...
implementation-visitor.cc Loading commit data...
implementation-visitor.h Loading commit data...
instructions.cc Loading commit data...
instructions.h Loading commit data...
parameter-difference.h Loading commit data...
server-data.cc Loading commit data...
server-data.h Loading commit data...
source-positions.cc Loading commit data...
source-positions.h Loading commit data...
torque-compiler.cc Loading commit data...
torque-compiler.h Loading commit data...
torque-parser.cc Loading commit data...
torque-parser.h Loading commit data...
torque.cc Loading commit data...
type-oracle.cc Loading commit data...
type-oracle.h Loading commit data...
types.cc Loading commit data...
types.h Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...