• Simon Zünd's avatar
    [torque] "OneOf" parser rule returns Identifier* instead of std::string · 7626fe35
    Simon Zünd authored
    To obtain SourcePositions for unary and binary operators, this CL
    changes the "OneOf" parser rule to produce an Identifier*. Forwarding
    this new identifier as callee for a CallExpression enables
    "goto Definition" support for operators in the Language Server.
    
    Side note: VSCode won't highlight operators with an underlined font
    when hovering with Ctrl pressed. "goto Definition" will work
    nonetheless using default F12 or Ctrl-Click.
    
    R=tebbi@chromium.org
    
    Bug: v8:7793
    Change-Id: Iada06009e324a3de8c453ec058427049e921a70d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598690
    Auto-Submit: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61263}
    7626fe35
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...