• Andreas Haas's avatar
    [arm64] Remove unnecessary calls to CPURegList::IsValid · 761a2e71
    Andreas Haas authored
    In the mjsunit/wasm/asm-wasm-f32 test, {IsValid} caused 10% of the
    overall runtime. In absolute numbers, {IsValid} wasm called more
    than 6.000.000.000 times. I moved the calls to {IsValid} from
    before-use to after-modification. I removed the calls in {Combine}
    and {Remove}, because these operations cannot create an invalid
    CPURegList.
    These changes reduce the number of calls to {IsValid} to about
    100.000.000 in the test mentioned above, and saves for that test
    about 10 seconds out of before 2 minutes absolute runtime.
    
    R=v8-arm-port@googlegroups.com
    
    Bug: v8:9396
    Change-Id: If3059f471e423405ec6f34ddef89e314dee1cbaf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801851
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMartyn Capewell <martyn.capewell@arm.com>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63864}
    761a2e71
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...