• Andreas Haas's avatar
    [arm64] Remove unnecessary calls to CPURegList::IsValid · 761a2e71
    Andreas Haas authored
    In the mjsunit/wasm/asm-wasm-f32 test, {IsValid} caused 10% of the
    overall runtime. In absolute numbers, {IsValid} wasm called more
    than 6.000.000.000 times. I moved the calls to {IsValid} from
    before-use to after-modification. I removed the calls in {Combine}
    and {Remove}, because these operations cannot create an invalid
    CPURegList.
    These changes reduce the number of calls to {IsValid} to about
    100.000.000 in the test mentioned above, and saves for that test
    about 10 seconds out of before 2 minutes absolute runtime.
    
    R=v8-arm-port@googlegroups.com
    
    Bug: v8:9396
    Change-Id: If3059f471e423405ec6f34ddef89e314dee1cbaf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801851
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMartyn Capewell <martyn.capewell@arm.com>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63864}
    761a2e71
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...