• Clemens Hammacher's avatar
    [wasm] Check for illegal br table count · 74519c43
    Clemens Hammacher authored
    The underlying issue is that TF Nodes cannot handle input counts
    outside the integer range. On an illegal br_table instruction, we
    generated a switch node with a control output count >kMaxInt.
    Operator::ControlOutputCount turned this into a negative integer later,
    leading to a failing DCHECK.
    Since such large numbers cannot occur in any valid wasm function anyway,
    we just add an additional check to the br table count. There is already
    a TODO in the code to change Operator::ControlOutputCount to size_t.
    
    R=ahaas@chromium.org
    BUG=chromium:722445
    
    Change-Id: I1975072226e073dee6c8da3b9fa9a050a4695917
    Reviewed-on: https://chromium-review.googlesource.com/505496Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45365}
    74519c43
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...