• Clemens Hammacher's avatar
    [wasm] Check for illegal br table count · 74519c43
    Clemens Hammacher authored
    The underlying issue is that TF Nodes cannot handle input counts
    outside the integer range. On an illegal br_table instruction, we
    generated a switch node with a control output count >kMaxInt.
    Operator::ControlOutputCount turned this into a negative integer later,
    leading to a failing DCHECK.
    Since such large numbers cannot occur in any valid wasm function anyway,
    we just add an additional check to the br table count. There is already
    a TODO in the code to change Operator::ControlOutputCount to size_t.
    
    R=ahaas@chromium.org
    BUG=chromium:722445
    
    Change-Id: I1975072226e073dee6c8da3b9fa9a050a4695917
    Reviewed-on: https://chromium-review.googlesource.com/505496Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45365}
    74519c43
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
DEPS.chromium Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...