• Seth Brenith's avatar
    [intl] Avoid a temporary allocation while converting to ICU string · 734c1456
    Seth Brenith authored
    If we need to build an icu::UnicodeString for a string that is currently
    in one-byte representation, we first have to expand the string's content
    into a two-byte representation. Doing so involves allocating an array,
    which is slow. With this change, we can convert short strings on the
    stack instead to save time. The cutoff length for what counts as "short"
    is pretty arbitrary, but we believe many strings fit into an 80-column
    line. This increases the score of cdjs in JetStream 2 by 35% on my
    machine, because cdjs is basically a test of localeCompare throughput.
    
    Bug: v8:9305
    
    Change-Id: Iba081ac5a8fa7659edf06ac97ba8acf3f8328d59
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630848
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61901}
    734c1456
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...