• Seth Brenith's avatar
    [intl] Avoid a temporary allocation while converting to ICU string · 734c1456
    Seth Brenith authored
    If we need to build an icu::UnicodeString for a string that is currently
    in one-byte representation, we first have to expand the string's content
    into a two-byte representation. Doing so involves allocating an array,
    which is slow. With this change, we can convert short strings on the
    stack instead to save time. The cutoff length for what counts as "short"
    is pretty arbitrary, but we believe many strings fit into an 80-column
    line. This increases the score of cdjs in JetStream 2 by 35% on my
    machine, because cdjs is basically a test of localeCompare throughput.
    
    Bug: v8:9305
    
    Change-Id: Iba081ac5a8fa7659edf06ac97ba8acf3f8328d59
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630848
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61901}
    734c1456
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...