• clemensh's avatar
    Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3... · 29ee6244
    clemensh authored
    Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3 id:40001 of https://codereview.chromium.org/2524093002/ )
    
    Reason for revert:
    Seems to cause compile errors on Android. Will investigate on Monday.
    
    Original issue's description:
    > [base] Pass scalar arguments by value in CHECK/DCHECK
    >
    > This not only potentially improves performance, but also avoids weird
    > linker errors, like the one below, where I used Smi::kMinValue in a
    > DCHECK_EQ.
    >
    > > [421/649] LINK ./mksnapshot
    > > FAILED: mksnapshot
    > > src/base/logging.h|178| error: undefined reference to
    >   'v8::internal::Smi::kMinValue'
    >
    > R=bmeurer@chromium.org, ishell@chromium.org
    >
    > Committed: https://crrev.com/76723502528c5af003fdffc3520632ea2a13fef3
    > Cr-Commit-Position: refs/heads/master@{#41273}
    
    TBR=bmeurer@chromium.org,ishell@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2527883004
    Cr-Commit-Position: refs/heads/master@{#41278}
    29ee6244
Name
Last commit
Last update
..
debug Loading commit data...
platform Loading commit data...
utils Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
adapters.h Loading commit data...
atomic-utils.h Loading commit data...
atomicops.h Loading commit data...
atomicops_internals_atomicword_compat.h Loading commit data...
atomicops_internals_portable.h Loading commit data...
atomicops_internals_x86_msvc.h Loading commit data...
base-export.h Loading commit data...
bits.cc Loading commit data...
bits.h Loading commit data...
build_config.h Loading commit data...
compiler-specific.h Loading commit data...
cpu.cc Loading commit data...
cpu.h Loading commit data...
division-by-constant.cc Loading commit data...
division-by-constant.h Loading commit data...
file-utils.cc Loading commit data...
file-utils.h Loading commit data...
flags.h Loading commit data...
format-macros.h Loading commit data...
free_deleter.h Loading commit data...
functional.cc Loading commit data...
functional.h Loading commit data...
hashmap-entry.h Loading commit data...
hashmap.h Loading commit data...
ieee754.cc Loading commit data...
ieee754.h Loading commit data...
iterator.h Loading commit data...
lazy-instance.h Loading commit data...
logging.cc Loading commit data...
logging.h Loading commit data...
macros.h Loading commit data...
once.cc Loading commit data...
once.h Loading commit data...
qnx-math.h Loading commit data...
ring-buffer.h Loading commit data...
safe_conversions.h Loading commit data...
safe_conversions_impl.h Loading commit data...
safe_math.h Loading commit data...
safe_math_impl.h Loading commit data...
sys-info.cc Loading commit data...
sys-info.h Loading commit data...
win32-headers.h Loading commit data...