• clemensh's avatar
    Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3... · 29ee6244
    clemensh authored
    Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3 id:40001 of https://codereview.chromium.org/2524093002/ )
    
    Reason for revert:
    Seems to cause compile errors on Android. Will investigate on Monday.
    
    Original issue's description:
    > [base] Pass scalar arguments by value in CHECK/DCHECK
    >
    > This not only potentially improves performance, but also avoids weird
    > linker errors, like the one below, where I used Smi::kMinValue in a
    > DCHECK_EQ.
    >
    > > [421/649] LINK ./mksnapshot
    > > FAILED: mksnapshot
    > > src/base/logging.h|178| error: undefined reference to
    >   'v8::internal::Smi::kMinValue'
    >
    > R=bmeurer@chromium.org, ishell@chromium.org
    >
    > Committed: https://crrev.com/76723502528c5af003fdffc3520632ea2a13fef3
    > Cr-Commit-Position: refs/heads/master@{#41273}
    
    TBR=bmeurer@chromium.org,ishell@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2527883004
    Cr-Commit-Position: refs/heads/master@{#41278}
    29ee6244
logging.h 7.2 KB