• Benedikt Meurer's avatar
    [debug] Always return a valid PropertyDescriptor. · 0de01928
    Benedikt Meurer authored
    In DebugPropertyIterator::iterator() we were assuming that the call to
    JSReceiver::GetOwnPropertyDescriptor() would always yield either an
    exception or a valid property descriptor. But that's not guaranteed to
    be the case (anymore), because JSReceiver::GetOwnPropertyDescriptor()
    nowadays can chicken out with `false` for many different reasons.
    
    Coincidentally the callsites to DebugPropertyIterator::iterator() are
    already equipped to handle the case where of an empty property
    descriptor, which is basically what we get out here. So this CL adjusts
    the DebugPropertyIterator to return an empty descriptor in this case.
    
    Fixed: chromium:1291240
    Change-Id: I22a9d0cde2b2c6d3966a85478ed0b87fb4c5d232
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736445Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81458}
    0de01928
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...