- 30 Jun, 2022 7 commits
-
-
Jakob Kummerow authored
Waiting for a background thread to finish a task isn't going to work when there are no background threads. Luckily, we can sidestep the problem by compiling with Turbofan immediately, instead of triggering dynamic tier-up through repeated execution. As a nice bonus, this makes the test faster in non-predictable modes too. Fixed: v8:13020 Change-Id: I2d47bc07bbde48a210c6ea59551ae16e63bdae05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736443Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81459}
-
Benedikt Meurer authored
In DebugPropertyIterator::iterator() we were assuming that the call to JSReceiver::GetOwnPropertyDescriptor() would always yield either an exception or a valid property descriptor. But that's not guaranteed to be the case (anymore), because JSReceiver::GetOwnPropertyDescriptor() nowadays can chicken out with `false` for many different reasons. Coincidentally the callsites to DebugPropertyIterator::iterator() are already equipped to handle the case where of an empty property descriptor, which is basically what we get out here. So this CL adjusts the DebugPropertyIterator to return an empty descriptor in this case. Fixed: chromium:1291240 Change-Id: I22a9d0cde2b2c6d3966a85478ed0b87fb4c5d232 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736445Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81458}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5b369fe..26f8da3 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ia7497d20609919082eef79230051053d61c8460d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3737363 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81457}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c76626e..322e254 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220627.3.1..version:8.20220629.1.1 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9406a60..af29db7 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I769c1ece184dd94a752cf17bcf890a11fc70dab4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735118 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81456}
-
Jakob Kummerow authored
Fixed: chromium:1340488 Change-Id: Id3da10dd13256dfc15a6fef4dc412b5d30ccc8cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735126Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81455}
-
Lu Yahan authored
port commit b9c4a849 Change-Id: Id2764f7b37b287a76bd9b22e55f4153b9b619bd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736554 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#81454}
-
Frank Tang authored
https://github.com/tc39/proposal-temporal/pull/1917 https://github.com/tc39/proposal-temporal/pull/1953 Bug: v8:11544 Change-Id: I667980e312248ccbaf826d4e3104fb1ddabef890 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721464 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81453}
-
- 29 Jun, 2022 28 commits
-
-
Anton Bikineev authored
Shifting negative integrals is undefined behavior. The CL simply switches to uint64_t when decompressing, which anyway results in sign-extension (in standard terms, integral promotion must preserve the value and the sign of the source operand). The CL doesn't have any functional changes, the generated code is the same. It only fixes the ubsan report. Bug: chromium:1325007 Change-Id: I491a87b84d4e98b0225f76825dac2f9e85f168d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736442 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81452}
-
Shu-yu Guo authored
Bug: v8:11111 Change-Id: I4846910d05bb5d83c964b2279efdb7cf2a4545b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3733028Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81451}
-
Jakob Kummerow authored
Change-Id: I172f684515e363fc29e299c70fa3d6eac2789818 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735127 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#81450}
-
Deepti Gandluri authored
This reverts commit b9821eff. Reason for revert: Tests fail on gc-stress: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/39147/overview Original change's description: > [stringrefs] Implement string.new_wtf16_array > > See https://github.com/WebAssembly/stringref/issues/1. > > Bug: v8:12868 > Change-Id: Iea3940c48d5f47609ff7d32e366d2f41d2161372 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3734808 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Andy Wingo <wingo@igalia.com> > Cr-Commit-Position: refs/heads/main@{#81448} Bug: v8:12868 Change-Id: I7abf8817c51057d9b984175ce162364acbb41ac4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735894 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#81449}
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/issues/1. Bug: v8:12868 Change-Id: Iea3940c48d5f47609ff7d32e366d2f41d2161372 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3734808Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andy Wingo <wingo@igalia.com> Cr-Commit-Position: refs/heads/main@{#81448}
-
Anton Bikineev authored
GCC doesn't have __attribute__((require_constant_initialization)). Use it only for clang. Bug: chromium:1325007 Change-Id: Ide5d428ed107d3244072774c0031c042ed0cee31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735125Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#81447}
-
Jakob Kummerow authored
NamesProvider class: This consolidates logic used so far for the debugger interface. It also adds support for the "extended name section" proposal: https://github.com/WebAssembly/extended-name-section StringBuilder class: Like std::ostringstream, but 4x faster for this use case. This lays the groundwork for an updated Wasm disassembler. Bug: v8:12917 Change-Id: I98aa258147834bc0e314ba98c5927b4cd6070b8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3720714Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#81446}
-
Toon Verwaest authored
We might be racing with code that resets the age to 0, causing CAS to fail (or us to read an already reset value). Change-Id: I3ba555d64d48c4e2d2399978427c764c0e6e7128 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735167 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81445}
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/issues/1. Bug: v8:12868 Change-Id: Ic1c9b55b1ec35c32c79d9b2cb0be243b96fc4453 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3734807 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81444}
-
Anton Bikineev authored
This reverts commit 4cf08c1a. Reason for revert: broke ubsan. Original change's description: > cppgc: Enable pointer compression by default on Desktop > > The CL enables pointer compression in Oilpan. > > For sherrifs: the CL may cause some slight perf regressions (likely > blink_perf.*), due to slightly higher cost of compression and > decomrpession. > > Speedometer2 is not expected to regress, as was checked locally. Such a > slight performance degradation is compensated by memory savings that are > expected to be around 10-20% of Oilpan committed size (~2.5-5% of Renderer > PMF). > > Bug: chromium:1325007 > Change-Id: I2e31fc56250dbe6354a7614fa1f9e926260d842b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695565 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81442} Bug: chromium:1325007 Change-Id: Iabc31ed683841ba0189dee9028da330dc03d7e09 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735168 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#81443}
-
Anton Bikineev authored
The CL enables pointer compression in Oilpan. For sherrifs: the CL may cause some slight perf regressions (likely blink_perf.*), due to slightly higher cost of compression and decomrpession. Speedometer2 is not expected to regress, as was checked locally. Such a slight performance degradation is compensated by memory savings that are expected to be around 10-20% of Oilpan committed size (~2.5-5% of Renderer PMF). Bug: chromium:1325007 Change-Id: I2e31fc56250dbe6354a7614fa1f9e926260d842b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695565 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81442}
-
Leszek Swirski authored
gcc warns against passing a nullptr to a printf '%s' string print, and the default args of varint consuming functions in the wasm decoder were providing a null name. Bug: chromium:1307180 Change-Id: I7a4e7a38119c2568025a597423d391a7c2c573f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735123 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81441}
-
Andy Wingo authored
Add parser support for wasm instructions that create stringrefs from GC arrays, and which encode strings to GC arrays. Bug: v8:12868 Change-Id: I38446855b7a55366f8107970811aec935defcdb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732935Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andy Wingo <wingo@igalia.com> Cr-Commit-Position: refs/heads/main@{#81440}
-
Marja Hölttä authored
In this part: indexOf, lastIndexOf Bug: v8:11111 Change-Id: I51481ccf44ad6c3ebc9216c1b6cc870fda73566e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3726209 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81439}
-
Michael Lippautz authored
The barrier is currently not thread-safe but may be executed via concurrent Sparkplug compilation. Remove the actual barrier code as the remembered set is anyways not used yet. Bug: v8:13018, chromium:1336850, chromium:1333414 Change-Id: I9287516d559cc3b10d170fa0fda36b26ca487a15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3734809 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#81438}
-
Toon Verwaest authored
Change-Id: Ia09e8c4528e59116be39be12d688f5b99a34c8e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732938Reviewed-by: Igor Sheludko <ishell@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81437}
-
Leszek Swirski authored
Fix some final gcc warnings: * Manually roll googletest to get the fix in: https://crrev.com/d5ad28dbe14fca51038fb8c7610f11602b98f682 * Remove some anonymous namespaces in tests because the types in those anonymous namespaces ended up being visible in non-anonymous classes. * Fix a RVO breaking std::move. * Change some known-too-short strncpys into memcpys Bug: chromium:1307180 Change-Id: I0f64512f77655f3740fc297bbb2087e6c039f7f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735122 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81436}
-
Leszek Swirski authored
Make sure that: * Temporaries are consistently free-but-blocked, * Blocked registers are ignored when processing free registers (where appropriate), * Fixed phis are processed before arbitrary register allocation, * Blocked state is set and cleared correctly * Opportunistic register moves on dropping don't block registers Bug: v8:7700 Change-Id: I2bc8884f70d9e54ce6ee2fb5bb600b028a9502c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732931 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81435}
-
Tobias Tebbi authored
Bug: chromium:1340335, chromium:1315901 Change-Id: Ic348e8a66df098f64cf1893f83c145ac7bdb1ecb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732939Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#81434}
-
Leszek Swirski authored
Bug: chromium:1307180 Change-Id: Ia279086ec3df9d64bd6a0255ebe27d9e583014c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732937Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81433}
-
Leszek Swirski authored
Bug: chromium:1307180 Change-Id: I45e01e172c04f5c0aac40cd84605ce52cb335cdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732934 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81432}
-
Leszek Swirski authored
Centralise constant visiting into the graph visitor, and adapt graph printing to print both the labeller node id, and the node numbering node id. Bug: v8:7700 Change-Id: I1af8f97e546f7113ac5655522f9206f207a0ae97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732932Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81431}
-
Leszek Swirski authored
Change-Id: Id3586eae6580416216bce2c448e6885aaa1589b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732111 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81430}
-
Omer Katz authored
Live bytes were accounted twice. Once when object is marked black and once explicitly by the marking task. Drop the accounting by the marking task. This should also help reduce binary size. Bug: v8:12612, chromium:1331317 Change-Id: I43e90413309709662b6fcd0dfdec96cac1b5f231 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732930 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81429}
-
Frank Tang authored
Also add AOs: FormatISOTimeZoneOffsetString, TemporalInstantToString, GetUnsignedRoundingMode, ApplyUnsignedRoundingMode, RoundTemporalInstant Also update the RoundNumberToIncrement implementation and a BigInt version. Fix the test setup in test/mjsunit/temporal/instant-to-json.js since fromEpochSeconds and fromEpochMilliseconds do not take BigInt Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tojson https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tolocalestring https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tostring https://tc39.es/proposal-temporal/#sec-temporal-temporalinstanttostring https://tc39.es/proposal-temporal/#sec-temporal-formatisotimezoneoffsetstring https://tc39.es/proposal-temporal/#sec-temporal-getunsignedroundingmode https://tc39.es/proposal-temporal/#sec-temporal-applyunsignedroundingmode https://tc39.es/proposal-temporal/#sec-temporal-roundtemporalinstant https://tc39.es/proposal-temporal/#sec-temporal-roundnumbertoincrement This does NOT implement the intl version of toLocaleString specified in (notice the "sup" not "sec" after #) yet. https://tc39.es/proposal-temporal/#sup-temporal.instant.prototype.tolocalestring Bug: v8:11544 Change-Id: I807afd5bf550d2a65a4732a8e536056eea79cf8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3696483 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81428}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.round Bug: v8:11544 Change-Id: I564cec6fdc030e3d39a9798c047534228f670dc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3692428 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81427}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4e6d71d..5b369fe R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7cad4152d9b673ae901483df006118086068d751 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3733340 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81426}
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/b5f3d3b..3007992 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/17a97ab..c76626e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3c4d401..a83ac93 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ib46c67b3afa845c1e77d92a15fcb3c6a15697756 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3733339 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81425}
-
- 28 Jun, 2022 5 commits
-
-
Milad Fa authored
Change-Id: I2ef7b64bc20e71898c96d8a5d6d5509065d578c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3733336Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#81424}
-
Michael Lippautz authored
- Remove dead code. - Remove `was_activated_`. Bug: v8:12775 Change-Id: Ie54b24f21a8789dc815ab7a96ce4a074e3644342 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3726300Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81423}
-
Anton Bikineev authored
Before this CL, the caged heap was lazily initialized upon the first call of HeapBase ctor. CagedHeap keeps a pointer to PageAllocator which was provided from cppgc::Platform through the HeapBase ctor. This was not generally safe: the platform is not enforced to be singleton. If it happens to die first, then CagedHeap will have a stale pointer. The CL fixes it simply by moving caged-heap initialization to cppgc::InitializeProcess(), which already requires a constantly living PageAllocator. Bug: chromium:1338030 Change-Id: Ifb70a2db233ef36a99c919db09bed9ff9f3708ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732107 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81422}
-
Andreas Haas authored
The class is dead code, and has not been used for years. I tried to deprecate the class first, but this caused build errors on GCC [1]. That's why this CL just deletes the class. Deleting the class is okay because this class was part of the original implementation of streaming compilation. There is only a single embedder who uses streaming compilation, which is Chrome, and Chrome switched to the new API already years ago. If there were other embedders that use this class, then this embedder would already have no working implementation of streaming compilation for years. R=adamk@chromium.org Bug: v8:12926 Change-Id: I3342167245822cf8ee52d9632cba236fb1b0646c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714236 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81421}
-
Mohit Saini authored
This is a reland of commit c801d529 perfetto::DynamicString was supported in perfetto very recently. This CL failed earlier because latest perfetto was not rolled in v8. Relanding it after rolling the latest perfetto in v8 (see parent CL). Original change's description: > Refactor dynamic name to perfetto::DynamicString > > Recently perfetto introduced `perfetto::DynamicString` to allow clients > to wrap dynamic event name strings. So that clients don't have to > manually set event name inside trace lambda. > > With that: > > TRACE_EVENT("cat", nullptr, [&](EventContext ctx) { > ctx.event().set_name(dynamic_name_str) > }); > > is simplified to: > > TRACE_EVENT("cat", perfetto::DynamicString{dynamic_name_str}); > > In this change we are making use of perfetto::DynamicString to pass > dynamic event name string. > > Change-Id: Ic6b501df67409d6faa4d60b59095ad0e79ce585e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716473 > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> > Commit-Queue: Mohit Saini <mohitms@google.com> > Cr-Commit-Position: refs/heads/main@{#81298} Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Change-Id: I70103606f397cd420a5dfccba703bee8962f822b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714946 Commit-Queue: Mohit Saini <mohitms@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Mohit Saini <mohitms@google.com> Cr-Commit-Position: refs/heads/main@{#81420}
-