• Ulan Degenbaev's avatar
    [inspector] Fix handling of on-heap TypedArrays in queryObjects() · 5ee9cf87
    Ulan Degenbaev authored
    On-heap TypedArrays have empty ArrayBuffers that are not supposed to be
    accessed directly. Such ArrayBuffers materialize properly when accessed
    via their TypedArrays.
    
    The queryObjects() sidesteps the bottleneck and finds empty ArrayBuffers
    by iterating the heap. When preview TypedArrays are constructed for the
    found ArrayBuffers, they get nullptr data pointers.
    
    This CL converts all on-heap TypedArrays into off-heap TypedArrays in
    queryObjects to make sure that all found ArrayBuffers are valid.
    
    Bug: chromium:992442
    Change-Id: Ie77d1e75aa2007b4a976c72206b9a4e215c9ef53
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150601
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67174}
    5ee9cf87
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...