• Ulan Degenbaev's avatar
    [inspector] Fix handling of on-heap TypedArrays in queryObjects() · 5ee9cf87
    Ulan Degenbaev authored
    On-heap TypedArrays have empty ArrayBuffers that are not supposed to be
    accessed directly. Such ArrayBuffers materialize properly when accessed
    via their TypedArrays.
    
    The queryObjects() sidesteps the bottleneck and finds empty ArrayBuffers
    by iterating the heap. When preview TypedArrays are constructed for the
    found ArrayBuffers, they get nullptr data pointers.
    
    This CL converts all on-heap TypedArrays into off-heap TypedArrays in
    queryObjects to make sure that all found ArrayBuffers are valid.
    
    Bug: chromium:992442
    Change-Id: Ie77d1e75aa2007b4a976c72206b9a4e215c9ef53
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150601
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67174}
    5ee9cf87
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...