• Ross McIlroy's avatar
    Revert "[compiler] Cache StateValue processing in InstructionSelector." · 5ddbc33b
    Ross McIlroy authored
    This reverts commit 812eb264.
    
    Reason for revert: clusterfuzz crashes
    
    Original change's description:
    > [compiler] Cache StateValue processing in InstructionSelector.
    >
    > Processing StateValues into operands is one of the most costly
    > parts of instruction selection. As it happens, StateValues are
    > shared by many nodes, and so we are unecessarily reprocessing
    > the same StateValues multiple times. This CL introduces caching
    > for the processed StateValues enabling very fast emitting of
    > operands for subsiquent instructions with the same StateValue.
    > The hitrate for the cache is higher than 90% on most optimizations.
    >
    > BUG=v8:9684
    >
    > Change-Id: I45db86dcbf22ab972b892f11c608b825aeb3ecf3
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749634
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73342}
    
    Bug: v8:9684
    Change-Id: I7d8121f91a0a7ed764add64f12f3954635921cfa
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756208
    Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#73361}
    5ddbc33b
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
code-generator-impl.h Loading commit data...
code-generator.cc Loading commit data...
code-generator.h Loading commit data...
frame-elider.cc Loading commit data...
frame-elider.h Loading commit data...
gap-resolver.cc Loading commit data...
gap-resolver.h Loading commit data...
instruction-codes.h Loading commit data...
instruction-scheduler.cc Loading commit data...
instruction-scheduler.h Loading commit data...
instruction-selector-impl.h Loading commit data...
instruction-selector.cc Loading commit data...
instruction-selector.h Loading commit data...
instruction.cc Loading commit data...
instruction.h Loading commit data...
jump-threading.cc Loading commit data...
jump-threading.h Loading commit data...
mid-tier-register-allocator.cc Loading commit data...
mid-tier-register-allocator.h Loading commit data...
move-optimizer.cc Loading commit data...
move-optimizer.h Loading commit data...
register-allocation.h Loading commit data...
register-allocator-verifier.cc Loading commit data...
register-allocator-verifier.h Loading commit data...
register-allocator.cc Loading commit data...
register-allocator.h Loading commit data...
spill-placer.cc Loading commit data...
spill-placer.h Loading commit data...
unwinding-info-writer.h Loading commit data...