• Ross McIlroy's avatar
    Revert "[compiler] Cache StateValue processing in InstructionSelector." · 5ddbc33b
    Ross McIlroy authored
    This reverts commit 812eb264.
    
    Reason for revert: clusterfuzz crashes
    
    Original change's description:
    > [compiler] Cache StateValue processing in InstructionSelector.
    >
    > Processing StateValues into operands is one of the most costly
    > parts of instruction selection. As it happens, StateValues are
    > shared by many nodes, and so we are unecessarily reprocessing
    > the same StateValues multiple times. This CL introduces caching
    > for the processed StateValues enabling very fast emitting of
    > operands for subsiquent instructions with the same StateValue.
    > The hitrate for the cache is higher than 90% on most optimizations.
    >
    > BUG=v8:9684
    >
    > Change-Id: I45db86dcbf22ab972b892f11c608b825aeb3ecf3
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749634
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73342}
    
    Bug: v8:9684
    Change-Id: I7d8121f91a0a7ed764add64f12f3954635921cfa
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756208
    Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#73361}
    5ddbc33b
instruction-selector.h 30.3 KB