• Dan Elphick's avatar
    [snapshot] Fix mksnapshot with warmup script · 5c7e24d7
    Dan Elphick authored
    This fixes an assertion failure in mksnapshot that when the read-only
    space is created for a second time, that its checksum should match the
    first time it was deserialized. However with warmup scripts in
    mksnapshot, the first run through doesn't deserialize it, but creates it
    from scratch.  Then the next time through it deserializes it which it
    doesn't expect and so crashes as there is no checksum to compare it to.
    
    This fixes it by only checking if is a last_checksum (e.g. that it was
    deserialized). Additionally CHECK that we never attempt to create the
    objects from scratch if previously deserialized from a snapshot.
    
    Bug: v8:10320
    Change-Id: I598e5298b68f45911e20533db91d7f24fea21045
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2102579Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66718}
    5c7e24d7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...