• Dan Elphick's avatar
    [snapshot] Fix mksnapshot with warmup script · 5c7e24d7
    Dan Elphick authored
    This fixes an assertion failure in mksnapshot that when the read-only
    space is created for a second time, that its checksum should match the
    first time it was deserialized. However with warmup scripts in
    mksnapshot, the first run through doesn't deserialize it, but creates it
    from scratch.  Then the next time through it deserializes it which it
    doesn't expect and so crashes as there is no checksum to compare it to.
    
    This fixes it by only checking if is a last_checksum (e.g. that it was
    deserialized). Additionally CHECK that we never attempt to create the
    objects from scratch if previously deserialized from a snapshot.
    
    Bug: v8:10320
    Change-Id: I598e5298b68f45911e20533db91d7f24fea21045
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2102579Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66718}
    5c7e24d7
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...