• Clemens Backes's avatar
    [wasm] Fix data race in lazy compilation · 591db5d9
    Clemens Backes authored
    Instead of updating the detected features set directly, use the
    synchronized {OnCompilationStopped} method.
    In order to avoid this error in the future, the whole
    {detected_features()} getter is removed, as it returns a pointer which
    can only be accessed when holding the mutex anyway. Also, the refactored
    code was the only user of this dangerous method.
    
    Drive-by: Pass the WasmFeatures set by value, since it's just an
    EnumSet.
    Drive-by 2: Remove a print line from the regression test which can be
    confusing if the test is picked up again by foozzie.
    
    R=ahaas@chromium.org
    CC=zhin@chromium.org
    
    Bug: v8:11357
    Change-Id: I75b5c8f35983d2bc1fd2b61adcb2ecfc18564f39
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653226Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72375}
    591db5d9
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...