- 27 Jan, 2021 31 commits
-
-
Clemens Backes authored
Instead of updating the detected features set directly, use the synchronized {OnCompilationStopped} method. In order to avoid this error in the future, the whole {detected_features()} getter is removed, as it returns a pointer which can only be accessed when holding the mutex anyway. Also, the refactored code was the only user of this dangerous method. Drive-by: Pass the WasmFeatures set by value, since it's just an EnumSet. Drive-by 2: Remove a print line from the regression test which can be confusing if the test is picked up again by foozzie. R=ahaas@chromium.org CC=zhin@chromium.org Bug: v8:11357 Change-Id: I75b5c8f35983d2bc1fd2b61adcb2ecfc18564f39 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653226Reviewed-by:Zhi An Ng <zhin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72375}
-
Ng Zhi An authored
We have saturated_cast from safe_conversions, use it in the interpreter instead of implementing it ourselves for each pair of types to convert between. Bug: v8:11074 Change-Id: I81115458d2bc456cbc3e4cd9fb40f01abe33246f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649147Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72374}
-
Ng Zhi An authored
Prototype these 6 instructions on arm64: - f64x2.convert_low_i32x4_s - f64x2.convert_low_i32x4_u - i32x4.trunc_sat_f64x2_s_zero - i32x4.trunc_sat_f64x2_u_zero - f32x4.demote_f64x2_zero - f64x2.promote_low_f32x4 Drive-by fix: - f64x2.promote_low_f32x4 accesses out of bounds for the global, the result only has 2 doubles - fcvtn in simulator needs to clear top bits of the Q reg Bug: v8:11265 Change-Id: Icfb3338942f0d0374448fdcfef3847a6e3ce8ff6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2644066Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72373}
-
Michael Lippautz authored
Expose kSupportsCompaction to be able to refer to it from other traits. Change-Id: I3a0870853fabfac993eff22886a0a31a52d90055 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653225 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72372}
-
Mythri A authored
Currently, feedback vectors are allocated on a fixed budget of 1024. In some cases it might be beneficial to allocate feedback vectors based on invocation count rather than fixed budget. For example, if we have a large function that is only run once. This cl adds an option to use interrupt budget based on the bytecode size. It kind of mimics invocation count. We would allocate feedback vectors early when we have loops which is also required. This flag is turned off by default. In followup cl, we will enable it and if the memory / performance tradeoff is good we might make it default. Change-Id: I9f7231119b5fd65fb3268e665e2e315fb2625e1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584960Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#72371}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: Iaa3cefc652657246fffe7998dd8faa9d008d9195 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652496 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72370}
-
Omer Katz authored
Sweep page by page in the space until we find a slot big enough for the current allocation. Bug: chromium:1056170 Change-Id: Id6dcf2d4db20268090b4626340bbed44f67d053c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649259 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#72369}
-
Nico Hartmann authored
Bug: chromium:1170261 Change-Id: Id2c5d18df892ece2823f7784dee4e69e54b7454c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652491 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#72368}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: Ia312e96b421d596d25cccf584c2df823bd9e1ea0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652498Reviewed-by:
-
Clemens Backes authored
The copy&relocate work is fully parallelizable. Even though it's not the bottleneck, there is no reason to restrict it to a single thread. R=thibaudm@chromium.org Bug: v8:11164 Change-Id: I7d0fea66b2a14e36cb60438cff84e4722b7a7993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2644949 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72366}
-
Clemens Backes authored
This is a reland of 0938188f. The test is skipped for now, until we figure out a way to make wasm code GC deterministic. Original change's description: > [wasm][debug] Garbage-collect stepping code > > All wasm code has an initial ref count of 1, in the expectation that it > will be added to the code table. When the code is removed from that > table, the ref count will be decremented. > Stepping code (and also other code under special circumstances) will not > be added to the code table though. Hence the ref count will never be > decremented below 1, and the code will never be garbage-collected. > > This CL fixes this, by decrementing the ref count if the code is not > added to the code table. > Note that the code will only be collected if no isolate is currently > using it, so it won't be collected while still in use for stepping. > > R=thibaudm@chromium.org > > Bug: chromium:1168564 > Change-Id: I3047753591cbc52689ca019e9548ec58c237b835 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649040 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72354} Bug: chromium:1168564 Cq-Include-Trybots: luci.v8.try:v8_linux64_asan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac64_asan_rel_ng Change-Id: Idb3baec713e0732e51e13b665ac6ac86fdfec969 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652488Reviewed-by:
-
Ulan Degenbaev authored
The naming follows the scheme outlined in bit.ly/v8-gc-stats-collection and in the UMA document referenced from it. Bug: chromium:1154636 Change-Id: I872520de06e62f58d771383fd87d8aa06386bf0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650213Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72364}
-
Clemens Backes authored
The bot is pretty red, so skip the test until we have a fix. TBR=zhin@chromium.org Bug: v8:11357 Change-Id: I38bad23ba66518f95de0f13017a6b408623a519d No-Try: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652493Reviewed-by:
-
Manos Koukoutos authored
ref.test, ref.cast, and br_on_cast instructions all need to type check a value against an rtt. With new classification functions on the horizon, the wasm-compiler code needed to be refactored to avoid excessive code duplication. This CL factors out a function TypeCheck that takes as arguments a set of three callbacks functions: a conditional success, a conditional failure, and a negated conditional failure. Each of RefTest, RefCast, and BrOnCast call TypeCheck with a different set of callbacks. Bug: v8:7748 Change-Id: I1dd8893fc26d5b0228f85587c9250706d0ce16cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2647262 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
cjihrig authored
--log-regexp was removed in https://codereview.chromium.org/2422593003. This commit removes references to that flag in src/logging/log.h. Change-Id: Idc965f06dd1f85370b5391c495ae113306655b75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2646246Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:1154636 Change-Id: I69fb396d5ed5d4fd2823bfb0db1d994517aead91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650212Reviewed-by:
-
Michael Lippautz authored
The API allows for querying - IsAllocationAllowed: Certain GC phases prohibit allocation which can be queried; Should be mostly used for debugging checks. - IsMarking: Allows for querying whether the garbage collector is currently marking. Bug: chromium:1056170 Change-Id: I20ba5fb5be9de6694e8418fa885920eb04bd75ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649257 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
According to the new wasm-gc spec, ref.cast should forward a null input without trapping. Bug: v8:7748 Change-Id: Ifee17f02a572e7028c14482bc94f0e1c7fc82a5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2647261 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit 0938188f. Reason for revert: new test times out on tsan: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/35152/overview Original change's description: > [wasm][debug] Garbage-collect stepping code > > All wasm code has an initial ref count of 1, in the expectation that it > will be added to the code table. When the code is removed from that > table, the ref count will be decremented. > Stepping code (and also other code under special circumstances) will not > be added to the code table though. Hence the ref count will never be > decremented below 1, and the code will never be garbage-collected. > > This CL fixes this, by decrementing the ref count if the code is not > added to the code table. > Note that the code will only be collected if no isolate is currently > using it, so it won't be collected while still in use for stepping. > > R=thibaudm@chromium.org > > Bug: chromium:1168564 > Change-Id: I3047753591cbc52689ca019e9548ec58c237b835 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649040 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72354} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: I84f84324d2c4a3cae2ae6b97f469e3f22b0e3b3f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1168564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652485Reviewed-by:
-
Mike Stanton authored
This change was made in one file as a prototype to see if we should do it elsewhere. Backing the change out as we aren't planning to continue the work into the other builders. Change-Id: I10f24a897d86b86d3c53288006cf41fb3255f1b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642376Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#72356}
-
Manos Koukoutos authored
This is a reland of b77deeca Changes compared to original: Add explicit narrowing casts in tests for MSVC. Original change's description: > [wasm-gc] Remove abstract rtts > > In the latest wasm-gc spec, rtts of abstract types are no longer > allowed. Consequently, canonical rtts of concrete types always have > a depth of 0. > > Changes: > - Change the immediate argument of rtts to a type index over a heap > type. Abstract it with TypeIndexImmediate in function body decoding. > This affects: > value_type.h, read_value_type(), decoding of relevant opcodes, > wasm subtyping, WasmInitExpr, consume_init_expr(), and > wasm-module-builder.cc. > - In function-body-decoder-impl.h, update rtt.canon to always produce > an rtt of depth 0. > - Pass a unit32_t type index over a HeapType to all rtt-related > utilities. > - Remove infrastructure for abstract-type rtts from the wasm compilers, > setup-heap-internal.cc, roots.h, and module-instantiate.cc. > - Remove ObjectReferenceKnowledge::rtt_is_i31. Remove related branches > from ref.test, ref.cast and br_on_cast implementations in the wasm > compilers. > - Remove unused 'parent' field from WasmTypeInfo. > - Make the parent argument optional in NewWasmTypeInfo, CreateStructMap, > and CreateArrayMap. > - Use more convenient arguments in IsHeapSubtypeOf. > - Update tests. > > Bug: v8:7748 > Change-Id: Ib45efe0741e6558c9b291fc8b4a75ae303146bdc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642248 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72321} Bug: v8:7748 Change-Id: I22b204b486fd185077cd6c7f15d492f5143f48fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650207 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Clemens Backes authored
All wasm code has an initial ref count of 1, in the expectation that it will be added to the code table. When the code is removed from that table, the ref count will be decremented. Stepping code (and also other code under special circumstances) will not be added to the code table though. Hence the ref count will never be decremented below 1, and the code will never be garbage-collected. This CL fixes this, by decrementing the ref count if the code is not added to the code table. Note that the code will only be collected if no isolate is currently using it, so it won't be collected while still in use for stepping. R=thibaudm@chromium.org Bug: chromium:1168564 Change-Id: I3047753591cbc52689ca019e9548ec58c237b835 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649040 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
... per code space. This avoids redudant work, including potentially locking the NativeModule. R=thibaudm@chromium.org Bug: v8:11164 Change-Id: I34d5aa9aaff5a487042889613676d2a8d96497e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2644948 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Start nodes for JS functions have the following Parameter node value outputs: closure, ...args_including_receiver, new_target, argc, context This CL adds helper functions for these. There's two interesting gotcha's: - Each Parameter node is associated with an index, starting at -1. Value output indices obviously start at 0, so there's an off-by-one between the value output of the Parameter node, and the Parameter node's associated index. - CSA/Torque graphs use different Start node layouts, yet these are not reflected in compiler logic. There's potential for confusion here. The two layouts should be unified or made explicit. Finally, tests create Start nodes with arbitrary layouts. This blocks removal of methods marked _MaybeNonStandardLayout. In an ideal world, the parameter index would equal the start node output index, and the layout of all Start nodes would be equal. Future work.. Change-Id: I908909880817979062d459b7a80ed4fede40e2ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649035 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#72352}
-
LiuYu authored
Port: 9db3cb75 Port: 22e06c7b Change-Id: Ib42f9729220365f1803cfbc634e3f37f5209e142 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650045 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72351}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/32fd3b2..fcaf1b1 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/450b6b6..71044df Rolling v8/buildtools/linux64: git_revision:d62642c920e6a0d1756316d225a90fd6faa9e21e..git_revision:55ad154c961d8326315b1c8147f4e504cd95e9e6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/957dfea..f8d79d2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1076f38..6d0c0ff Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/94a96af..eb5ab41 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic3d42a67d8590ee5f1d0c7cc7d6df3848372b337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2651163Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72350}
-
Milad Fa authored
If a lazy compilation happens in between 2 Wasm calls, we need to save the full Simd register, since we can have live v128 values. Port: 3b302d5c Bug: chromium:1161555 Change-Id: Id79c609cc01e896f48aff39fdcbf4aa76ae6996e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649260Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72349}
-
Ng Zhi An authored
Use external references to hold splat values. Bug: v8:11349,v8:11086 Change-Id: I829d136ae7c7f8e28de991d06f6a321551402ae1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2648972Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11215 Change-Id: I311729509f40ff6e03fc93ef4abdf3b3ce3a65e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650766Reviewed-by:
-
Michael Lippautz authored
WeakMember references are used in ephemerons which uses the ordinary LivenessBroker for determining whether an object is dead or not. Bug: chromium:1056170 Change-Id: I7f25da22637fba24603bccb76e266357b0371525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649042 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Add reporting of C++ memory to V8's heap growing strategy via existing EmbedderHeapTracer interface. In addition, introduce API-level NoGarbageCollectionScope which allows to temporarily avoid scheduling GC finalizations. Replace internal NoGCScope with NoGarbageCollectionScope and remove NoGCScope. Bug: chromium:1056170 Change-Id: I0ad3dfd67eb81f09f48e2ab87f9bbece7491ed71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650210 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
- 26 Jan, 2021 9 commits
-
-
Adam Klein authored
This reverts commit 3a405b01. Reason for revert: thread-sanitizer failures on Linux64 TSAN bot: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/35141/overview Original change's description: > [cpu-profiler] Implement weak phantom finalizers for CodeMap entries > > Listen to code deletion events by registering finalizers on code > objects, a first stab at non-leaky long-lived code entries. > > Bug: v8:11054 > Change-Id: Ieaaa5b63508263bd261e8385f5bf5dd3baedf9c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2628587 > Commit-Queue: Andrew Comminos <acomminos@fb.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72342} TBR=ulan@chromium.org,petermarshall@chromium.org,acomminos@fb.com Change-Id: If22a893af469c9d4d3e00fb124c42cdc52b9a19b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11054 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649156Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72344}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I00511c69e9681a80993bcb8ddb370030fc3d208c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649030 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Andrew Comminos authored
Listen to code deletion events by registering finalizers on code objects, a first stab at non-leaky long-lived code entries. Bug: v8:11054 Change-Id: Ieaaa5b63508263bd261e8385f5bf5dd3baedf9c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2628587 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#72342}
-
Milad Fa authored
Port 906b9644 Original Commit Message: This is merged into the proposal: https://github.com/WebAssembly/simd/issues/419#issuecomment-765675472. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I801c4337e2ea4671ef82cb1244b8da251d56fc2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650242Reviewed-by:
-
Milad Fa authored
Multi byte values get stored on native host order when arrays are being constructed, however as Wasm is LE enforced, they get reversed on BE machines during simd load. This causes incorrect values loaded into vector registers. This CL will force mask elements to be saved in byte sizes to eliminate endianness issues. Change-Id: I7f2e5017664234e01fc8b51a95cdd852a418b651 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2645586Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10975 Change-Id: I40b0c2c36553b44a510f8519b53195ab97f6f5a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2645474 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10975 Change-Id: I7d69b533fda8be369afe949699eea5abddda9a5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2645469 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I96abe7c2b2a2c988867dda3cf823f11c00ddec87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650234Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72337}
-
Ng Zhi An authored
movups is slower on older hardware (core2) than movaps, even if the operand is aligned. (Not an issue on modern hardware). Also move i8x16.splat(0x0F) to an external reference so we can load the mask directly. Bug: v8:11002 Change-Id: I0b01c27a142024d50b9faaa9e7bd6a1fe169e141 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2643242Reviewed-by:
-
