• Clemens Backes's avatar
    [wasm] Tweak constants for estimating code space size · 4e983705
    Clemens Backes authored
    It turned out that on arm and arm64 we over-estimated the code size of a
    Wasm module quite a bit. This CL adds some more output for the
    --trace-wasm-compilation-times flag, and adds a script to compute the
    factors we use for code size estimates from that output.
    I ran the script on a few benchmarks (an older Epic module, the current
    Photoshop module, and the benchmark from the linked bug), and adjusted
    the constants accordingly.
    
    Also, simplify the API of {ReservationSize} to only return a single
    number, and fail internally if we need to allocate more than the engine
    supports (which would only fail for artificially large modules).
    
    R=jkummerow@chromium.org
    
    Bug: chromium:1302310
    Change-Id: I5b2c27ff3e360fb6738cf5dd697bcee09e106b6d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3522067Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79482}
    4e983705
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...