• Ross McIlroy's avatar
    [TurboProp] Remove unreachable successor basic blocks from schedule. · 4a2ef63c
    Ross McIlroy authored
    Effect-control-linearizer will update a basic block to connect it
    directly to the end node if it has an Unreachable node. Usually the
    block would already have been connected directly to end (via a Throw
    node) already, however in some cases it can be connected indirectly
    (via a branch, where both end in a throw node).
    
    If this happens, and the Effect-control-linearizer is maintaining the
    schedule (e.g., for TurboProp), it will cause the end block to have
    unreachable predecessor blocks, which can cause issues with the
    register allocator.
    
    To fix this, have the BasicBlockUpdater remove all successor blocks
    from the schedule, when they become Unreachable. Also add some tests
    to cover this in effect-control-linearizer-unittests.
    
    BUG=v8:10332,v8:9684
    
    Change-Id: Ibce140e6d1f61751a86247e6f8c36075723a1e55
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120537
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66994}
    4a2ef63c
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...