• Ross McIlroy's avatar
    [TurboProp] Remove unreachable successor basic blocks from schedule. · 4a2ef63c
    Ross McIlroy authored
    Effect-control-linearizer will update a basic block to connect it
    directly to the end node if it has an Unreachable node. Usually the
    block would already have been connected directly to end (via a Throw
    node) already, however in some cases it can be connected indirectly
    (via a branch, where both end in a throw node).
    
    If this happens, and the Effect-control-linearizer is maintaining the
    schedule (e.g., for TurboProp), it will cause the end block to have
    unreachable predecessor blocks, which can cause issues with the
    register allocator.
    
    To fix this, have the BasicBlockUpdater remove all successor blocks
    from the schedule, when they become Unreachable. Also add some tests
    to cover this in effect-control-linearizer-unittests.
    
    BUG=v8:10332,v8:9684
    
    Change-Id: Ibce140e6d1f61751a86247e6f8c36075723a1e55
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120537
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66994}
    4a2ef63c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...