• Thibaud Michaud's avatar
    Revert "[codegen] Use xchg instead of push/pop for swap" · 468d5be7
    Thibaud Michaud authored
    This reverts commit c1ea574e.
    
    Reason for revert: We'd need to investigate on a range of hardware
    generations to assess if this is a good change; in general new
    hardware (intel 9th gen / amd ryzen) seems to be happier with
    xchg, while older hardware is not happy with xchg.
    
    Original change's description:
    > [codegen] Use xchg instead of push/pop for swap
    >
    > R=​sigurds@chromium.org
    >
    > Change-Id: Id22a44fa15827d5c076496d872fe3be7da360b5e
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678356
    > Auto-Submit: Thibaud Michaud <thibaudm@chromium.org>
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62383}
    
    TBR=sigurds@chromium.org,thibaudm@chromium.org
    
    Change-Id: Ieecbbc21fa7094fdfd190b266f6d8486ee8611b8
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679494Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62404}
    468d5be7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...