• Thibaud Michaud's avatar
    Revert "[codegen] Use xchg instead of push/pop for swap" · 468d5be7
    Thibaud Michaud authored
    This reverts commit c1ea574e.
    
    Reason for revert: We'd need to investigate on a range of hardware
    generations to assess if this is a good change; in general new
    hardware (intel 9th gen / amd ryzen) seems to be happier with
    xchg, while older hardware is not happy with xchg.
    
    Original change's description:
    > [codegen] Use xchg instead of push/pop for swap
    >
    > R=​sigurds@chromium.org
    >
    > Change-Id: Id22a44fa15827d5c076496d872fe3be7da360b5e
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678356
    > Auto-Submit: Thibaud Michaud <thibaudm@chromium.org>
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62383}
    
    TBR=sigurds@chromium.org,thibaudm@chromium.org
    
    Change-Id: Ieecbbc21fa7094fdfd190b266f6d8486ee8611b8
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679494Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62404}
    468d5be7
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...