• Andreas Haas's avatar
    [d8] Avoid lock-order-inversion warning in the DefaultPlatform · 40a5328b
    Andreas Haas authored
    This CL fixes two lock-order-inversion warning in the DefaultPlatform.
    The problem was that during shutdown locks get taken in the oposite
    order than during initialization.
    
    The first two conflicting locks were the WasmEngine lock and the
    lock of the DefaultTaskRunner. During WasmEngine initialization, when
    the WasmEngine lock is hold, a foreground task is scheduled, which
    requires the TaskRunner lock. During shutdown, the task queue of the
    TaskRunner gets drained while holding the TaskRunner lock. Thereby
    the destructors of the tasks get executed, and the LogCode task of
    the WasmEngine thereby acquires the WasmEngine lock.
    
    The second conflict happens between the WasmEngine lock and the
    DefaultPlatform lock, where the DefaultPlatform lock is taken during
    WasmEngine initialization when the ForegroundTaskrunner is acquired.
    During Shutdown, the DefaultPlatform lock was hold while the task
    queue was drained, as described above.
    
    Bug: chromium:1346250
    Change-Id: Ib67d0c6cad1372e7c592f40bbe68b0ae31b2976b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782796
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81911}
    40a5328b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...