• Andreas Haas's avatar
    [arm] Fix off-by-1 issue with stack returns · 3caf0f20
    Andreas Haas authored
    On 32-bit platforms, float64 stack returns take 2 stack slots. In the
    implemention of the kArmPeek instruction we assume that provided slot
    index points to the first stack slot. However, due to an off-by-1 issue
    the provided slot index pointed to the second stack slot. This CL fixes
    the problem and generalizes an existing test which reproduces it.
    
    R=v8-arm-ports@googlegroups.com
    
    Change-Id: Ibb2fd8275cf912da064e2f863c2d64d2526caaac
    Reviewed-on: https://chromium-review.googlesource.com/839761Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50291}
    3caf0f20
Name
Last commit
Last update
..
c-signature.h Loading commit data...
call-tester.h Loading commit data...
code-assembler-tester.h Loading commit data...
codegen-tester.cc Loading commit data...
codegen-tester.h Loading commit data...
function-tester.cc Loading commit data...
function-tester.h Loading commit data...
graph-builder-tester.h Loading commit data...
test-basic-block-profiler.cc Loading commit data...
test-branch-combine.cc Loading commit data...
test-code-assembler.cc Loading commit data...
test-code-generator.cc Loading commit data...
test-gap-resolver.cc Loading commit data...
test-graph-visualizer.cc Loading commit data...
test-instruction.cc Loading commit data...
test-js-constant-cache.cc Loading commit data...
test-js-context-specialization.cc Loading commit data...
test-js-typed-lowering.cc Loading commit data...
test-jump-threading.cc Loading commit data...
test-linkage.cc Loading commit data...
test-loop-analysis.cc Loading commit data...
test-machine-operator-reducer.cc Loading commit data...
test-multiple-return.cc Loading commit data...
test-node.cc Loading commit data...
test-operator.cc Loading commit data...
test-representation-change.cc Loading commit data...
test-run-bytecode-graph-builder.cc Loading commit data...
test-run-calls-to-external-references.cc Loading commit data...
test-run-deopt.cc Loading commit data...
test-run-intrinsics.cc Loading commit data...
test-run-jsbranches.cc Loading commit data...
test-run-jscalls.cc Loading commit data...
test-run-jsexceptions.cc Loading commit data...
test-run-jsobjects.cc Loading commit data...
test-run-jsops.cc Loading commit data...
test-run-load-store.cc Loading commit data...
test-run-machops.cc Loading commit data...
test-run-native-calls.cc Loading commit data...
test-run-stackcheck.cc Loading commit data...
test-run-stubs.cc Loading commit data...
test-run-tail-calls.cc Loading commit data...
test-run-unwinding-info.cc Loading commit data...
test-run-variables.cc Loading commit data...
test-run-wasm-machops.cc Loading commit data...
value-helper.cc Loading commit data...
value-helper.h Loading commit data...