• Andreas Haas's avatar
    [arm] Fix off-by-1 issue with stack returns · 3caf0f20
    Andreas Haas authored
    On 32-bit platforms, float64 stack returns take 2 stack slots. In the
    implemention of the kArmPeek instruction we assume that provided slot
    index points to the first stack slot. However, due to an off-by-1 issue
    the provided slot index pointed to the second stack slot. This CL fixes
    the problem and generalizes an existing test which reproduces it.
    
    R=v8-arm-ports@googlegroups.com
    
    Change-Id: Ibb2fd8275cf912da064e2f863c2d64d2526caaac
    Reviewed-on: https://chromium-review.googlesource.com/839761Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50291}
    3caf0f20
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...