• Omer Katz's avatar
    cppgc: Explicitly fail on V8 target with cppgc_is_standalone · 37c7eb27
    Omer Katz authored
    building the unittests target for example fails when cppgc_is_standalone
    is set to true due to conflicting implementations of trace-event.h. It
    is not clear from the output for these failures that V8 targets cannot
    be built with cppgc_is_standalone.
    We could disable all non-cppgc targets that depend on cppgc when
    cppgc_is_standalone is set, but that would be fragile and dirty.
    Since all V8 targets need to include cppgc-js headers, adding a  static
    assert in cpp-heap.h would cover all V8 targets. The static assert
    doesn't hide the current output, butadds a clear and expllicit message
    stating that it cannot be done.
    
    Bug: chromium:1056170
    Change-Id: I8bd1b1a5ada18d9688e6b78de4693386539d78bf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826535Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73968}
    37c7eb27
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...