• Omer Katz's avatar
    cppgc: Explicitly fail on V8 target with cppgc_is_standalone · 37c7eb27
    Omer Katz authored
    building the unittests target for example fails when cppgc_is_standalone
    is set to true due to conflicting implementations of trace-event.h. It
    is not clear from the output for these failures that V8 targets cannot
    be built with cppgc_is_standalone.
    We could disable all non-cppgc targets that depend on cppgc when
    cppgc_is_standalone is set, but that would be fragile and dirty.
    Since all V8 targets need to include cppgc-js headers, adding a  static
    assert in cpp-heap.h would cover all V8 targets. The static assert
    doesn't hide the current output, butadds a clear and expllicit message
    stating that it cannot be done.
    
    Bug: chromium:1056170
    Change-Id: I8bd1b1a5ada18d9688e6b78de4693386539d78bf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826535Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73968}
    37c7eb27
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...