• Benedikt Meurer's avatar
    [debugger] Don't attach source positions to implicit returns. · 379331b7
    Benedikt Meurer authored
    Previously we'd attach source positions to implicit returns that are
    generated when leaving an async function with a promise rejection. This
    was due to the use of `kNoSourcePosition` on the `end_position` in the
    `ReturnStatement` nodes as indicator to pick the return position from
    the function literal, instead of really not putting a source position on
    that specific `Return` bytecode.
    
    This CL adds a dedicated marker to `ReturnStatement` to express that the
    `BytecodeGenerator` should put the return position from the function
    literal there instead of overloading the meaning of `kNoSourcePosition`.
    
    Bug: chromium:901819, chromium:782461
    Fixed: chromium:1199919, chromium:1201706
    Change-Id: I3647e0c3d711e9c3d6ae44606b70ec92ad82e1cf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859945
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74301}
    379331b7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...