• littledan's avatar
    Make Promise.all/Promise.race catch prediction conditional on DevTools · 37735851
    littledan authored
    To improve performance, this patch makes Promise.all and Promise.race not
    perform correct catch prediction when the debugger is not open. The case
    may come up if Promise.race or Promise.all is called, then DevTools is
    open, then a component Promise is rejected. In this case, the user would
    falsely get an exception event even if the "pause on caught exceptions"
    box is unchecked. There are tests which triggered this case; however, it
    seems both unlikely and and acceptable to have an event in this case.
    Many analogous events are already produced when DevTools is enabled
    during the operation of a program.
    
    BUG=v8:3093
    
    Review-Url: https://codereview.chromium.org/2350363002
    Cr-Commit-Position: refs/heads/master@{#39565}
    37735851
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
fuzzer Loading commit data...
inspector_protocol_parser_test Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...