• littledan's avatar
    Make Promise.all/Promise.race catch prediction conditional on DevTools · 37735851
    littledan authored
    To improve performance, this patch makes Promise.all and Promise.race not
    perform correct catch prediction when the debugger is not open. The case
    may come up if Promise.race or Promise.all is called, then DevTools is
    open, then a component Promise is rejected. In this case, the user would
    falsely get an exception event even if the "pause on caught exceptions"
    box is unchecked. There are tests which triggered this case; however, it
    seems both unlikely and and acceptable to have an event in this case.
    Many analogous events are already produced when DevTools is enabled
    during the operation of a program.
    
    BUG=v8:3093
    
    Review-Url: https://codereview.chromium.org/2350363002
    Cr-Commit-Position: refs/heads/master@{#39565}
    37735851
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...