• Théotime Grohens's avatar
    [dataview] Fix too tight TNode type in DataView getters · 3656b465
    Théotime Grohens authored
    This CL fixes a bug found by Clusterfuzz, in which the functions
    LoadDataViewByteOffset and -ByteLength incorrectly had a return
    type of TNode<Smi> instead of TNode<Number>.
    
    This caused a CAST() call to fail when the requested byte offset
    or byte length did not fit inside a Smi, i.e. when the underlying
    ArrayBuffer of the DataView had a length longer than 2^30 on
    32-bit platforms.
    
    The CL also includes a new test in mjsunit to test against this.
    
    Bug: chromium:869313
    Change-Id: Ibb7d29bda5782a12c4b506c070bb03fef8c3ec70
    Reviewed-on: https://chromium-review.googlesource.com/1158582
    Commit-Queue: Théotime Grohens <theotime@google.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54900}
    3656b465
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...