• Jakob Kummerow's avatar
    Reland "[wasm] Fix tier-up budget tracking for recursive calls" · 6f398553
    Jakob Kummerow authored
    This is a reland of commit 15f372af
    
    Change since revert: TSan fix for tier-up budget reset.
    
    Original change's description:
    > [wasm] Fix tier-up budget tracking for recursive calls
    >
    > In the previous implementation, functions overwrote any budget
    > decrements caused by recursive invocations of themselves, which
    > could cause tier-up decisions for certain unlucky functions to
    > get delayed unreasonably long.
    > This patch avoids this by working with the on-instance value
    > directly instead of caching it in a stack slot. That generates
    > the same amount of Liftoff code as the status quo, but handles
    > recursive functions properly.
    > The "barista3" benchmark's peak performance improves by almost 20%.
    >
    > Bug: v8:12281
    > Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710
    > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#81249}
    
    Bug: v8:12281,v8:12984
    Change-Id: Ia6ce776848dc86617546ec514660c9a840484cb1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716479Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81281}
    6f398553
Name
Last commit
Last update
..
baseline Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
assembler-buffer-cache.cc Loading commit data...
assembler-buffer-cache.h Loading commit data...
branch-hint-map.h Loading commit data...
c-api.cc Loading commit data...
c-api.h Loading commit data...
canonical-types.cc Loading commit data...
canonical-types.h Loading commit data...
code-space-access.cc Loading commit data...
code-space-access.h Loading commit data...
compilation-environment.h Loading commit data...
constant-expression-interface.cc Loading commit data...
constant-expression-interface.h Loading commit data...
constant-expression.cc Loading commit data...
constant-expression.h Loading commit data...
decoder.h Loading commit data...
function-body-decoder-impl.h Loading commit data...
function-body-decoder.cc Loading commit data...
function-body-decoder.h Loading commit data...
function-compiler.cc Loading commit data...
function-compiler.h Loading commit data...
graph-builder-interface.cc Loading commit data...
graph-builder-interface.h Loading commit data...
jump-table-assembler.cc Loading commit data...
jump-table-assembler.h Loading commit data...
leb-helper.h Loading commit data...
local-decl-encoder.cc Loading commit data...
local-decl-encoder.h Loading commit data...
memory-protection-key.cc Loading commit data...
memory-protection-key.h Loading commit data...
memory-tracing.cc Loading commit data...
memory-tracing.h Loading commit data...
module-compiler.cc Loading commit data...
module-compiler.h Loading commit data...
module-decoder.cc Loading commit data...
module-decoder.h Loading commit data...
module-instantiate.cc Loading commit data...
module-instantiate.h Loading commit data...
object-access.h Loading commit data...
signature-map.cc Loading commit data...
signature-map.h Loading commit data...
simd-shuffle.cc Loading commit data...
simd-shuffle.h Loading commit data...
stacks.h Loading commit data...
streaming-decoder.cc Loading commit data...
streaming-decoder.h Loading commit data...
struct-types.h Loading commit data...
sync-streaming-decoder.cc Loading commit data...
value-type.cc Loading commit data...
value-type.h Loading commit data...
wasm-arguments.h Loading commit data...
wasm-code-manager.cc Loading commit data...
wasm-code-manager.h Loading commit data...
wasm-constants.h Loading commit data...
wasm-debug.cc Loading commit data...
wasm-debug.h Loading commit data...
wasm-engine.cc Loading commit data...
wasm-engine.h Loading commit data...
wasm-external-refs.cc Loading commit data...
wasm-external-refs.h Loading commit data...
wasm-feature-flags.h Loading commit data...
wasm-features.cc Loading commit data...
wasm-features.h Loading commit data...
wasm-import-wrapper-cache.cc Loading commit data...
wasm-import-wrapper-cache.h Loading commit data...
wasm-init-expr.cc Loading commit data...
wasm-init-expr.h Loading commit data...
wasm-js.cc Loading commit data...
wasm-js.h Loading commit data...
wasm-limits.h Loading commit data...
wasm-linkage.h Loading commit data...
wasm-module-builder.cc Loading commit data...
wasm-module-builder.h Loading commit data...
wasm-module-sourcemap.cc Loading commit data...
wasm-module-sourcemap.h Loading commit data...
wasm-module.cc Loading commit data...
wasm-module.h Loading commit data...
wasm-objects-inl.h Loading commit data...
wasm-objects.cc Loading commit data...
wasm-objects.h Loading commit data...
wasm-objects.tq Loading commit data...
wasm-opcodes-inl.h Loading commit data...
wasm-opcodes.cc Loading commit data...
wasm-opcodes.h Loading commit data...
wasm-result.cc Loading commit data...
wasm-result.h Loading commit data...
wasm-serialization.cc Loading commit data...
wasm-serialization.h Loading commit data...
wasm-subtyping.cc Loading commit data...
wasm-subtyping.h Loading commit data...
wasm-tier.h Loading commit data...
wasm-value.h Loading commit data...