• Andreas Haas's avatar
    [wasm][streaming] Avoid aborting the stream after it finished · 32dd5470
    Andreas Haas authored
    With WebAssembly streaming compilation it is possible that FinishStream
    indirectly calls AbortStream. This had the effect that while
    FinishStream fulfilled the promise, AbortStream disposed the promise
    by removing the compile job from the wasm engine and thereby deallocated
    AsyncCompileJob and all the state that belongs to it. Without that
    state, FinishStream could not finish fulfilling the promise correctly.
    
    With this CL the streaming decoder remembers that the stream has
    already been finished. When the stream has been finished, all calls to
    Abort get ignored.
    
    The regression test for this issue requires the Chrome embedding, see
    https://crrev.com/c/2368359
    
    R=clemensb@chromium.org
    
    Bug: chromium:1117258
    Change-Id: Ifc28a1ee38c228b051c4d7d85b305fe2a721fa1f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367858
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69549}
    32dd5470
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...