• Andreas Haas's avatar
    [wasm][streaming] Avoid aborting the stream after it finished · 32dd5470
    Andreas Haas authored
    With WebAssembly streaming compilation it is possible that FinishStream
    indirectly calls AbortStream. This had the effect that while
    FinishStream fulfilled the promise, AbortStream disposed the promise
    by removing the compile job from the wasm engine and thereby deallocated
    AsyncCompileJob and all the state that belongs to it. Without that
    state, FinishStream could not finish fulfilling the promise correctly.
    
    With this CL the streaming decoder remembers that the stream has
    already been finished. When the stream has been finished, all calls to
    Abort get ignored.
    
    The regression test for this issue requires the Chrome embedding, see
    https://crrev.com/c/2368359
    
    R=clemensb@chromium.org
    
    Bug: chromium:1117258
    Change-Id: Ifc28a1ee38c228b051c4d7d85b305fe2a721fa1f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367858
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69549}
    32dd5470
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...