• Toon Verwaest's avatar
    [interpreter/runtime] Simplify how global declarations are processed · 3113535e
    Toon Verwaest authored
    This makes the code a little more specific to what's happening: There is only 1
    global scope, and if there is one, we know its declarations are
    info->scope()->declarations(). That means we don't need multiple
    GlobalDeclarationsBuilders, and we don't need to cache partially serialized
    versions of the declarations. One builder is enough, and we can simply walk
    those declarations if there are any.
    
    Additionally this CL drops unnecessary information passed into DeclareGlobals:
    - Global functions always have the name on the shared function info, so we can
      drop the name.
    - Due to lazy feedback vectors there's no point in trying to preinitialize
      global loads. Also this was only preinitializing global loads at the script
      level, not sub functions; without even checking whether the global load was
      used. It may actually have caused us to do more work and allocate more global
      load feedback slots than neccessary.
    
    Change-Id: Ibbdd029abe5a39ba27f7fc9be84670c5d444d98d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997123
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65725}
    3113535e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...