• Toon Verwaest's avatar
    [interpreter/runtime] Simplify how global declarations are processed · 3113535e
    Toon Verwaest authored
    This makes the code a little more specific to what's happening: There is only 1
    global scope, and if there is one, we know its declarations are
    info->scope()->declarations(). That means we don't need multiple
    GlobalDeclarationsBuilders, and we don't need to cache partially serialized
    versions of the declarations. One builder is enough, and we can simply walk
    those declarations if there are any.
    
    Additionally this CL drops unnecessary information passed into DeclareGlobals:
    - Global functions always have the name on the shared function info, so we can
      drop the name.
    - Due to lazy feedback vectors there's no point in trying to preinitialize
      global loads. Also this was only preinitializing global loads at the script
      level, not sub functions; without even checking whether the global load was
      used. It may actually have caused us to do more work and allocate more global
      load feedback slots than neccessary.
    
    Change-Id: Ibbdd029abe5a39ba27f7fc9be84670c5d444d98d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997123
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65725}
    3113535e
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...