• Marja Hölttä's avatar
    [bootstrapper] Remove erroneous DCHECK · 30c60f38
    Marja Hölttä authored
    The DCHECK is true in the current V8 / Chrome. However, an embedder
    can create a snapshot where the object in question has dictionary
    properties (by using the object as a prototype). When reading the
    snapshot, in the object already has dictionary properties, and adding a
    property to it won't change it.
    
    The erroneous DCHECK was used to assert that adding a property to an
    object won't turn it to dictionary mode. But now it's in the wrong
    place, since this part of the code is executed after reading the
    snapshot in.
    
    The corresponding DCHECKs which are executed when setting up the objects
    before snapshot creation are still valid.
    
    Fixing the behavior wrt whether the object should turn dictionary
    mode or whether it should turn back is beyond the scope of this CL.
    
    See https://github.com/nodejs/node-v8/issues/160
    
    Bug: v8:10479
    Change-Id: Ie62c80495d4f4494eeb3a16b5bfe02305c0cac95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246577Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68357}
    30c60f38
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...