• Marja Hölttä's avatar
    [bootstrapper] Remove erroneous DCHECK · 30c60f38
    Marja Hölttä authored
    The DCHECK is true in the current V8 / Chrome. However, an embedder
    can create a snapshot where the object in question has dictionary
    properties (by using the object as a prototype). When reading the
    snapshot, in the object already has dictionary properties, and adding a
    property to it won't change it.
    
    The erroneous DCHECK was used to assert that adding a property to an
    object won't turn it to dictionary mode. But now it's in the wrong
    place, since this part of the code is executed after reading the
    snapshot in.
    
    The corresponding DCHECKs which are executed when setting up the objects
    before snapshot creation are still valid.
    
    Fixing the behavior wrt whether the object should turn dictionary
    mode or whether it should turn back is beyond the scope of this CL.
    
    See https://github.com/nodejs/node-v8/issues/160
    
    Bug: v8:10479
    Change-Id: Ie62c80495d4f4494eeb3a16b5bfe02305c0cac95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246577Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68357}
    30c60f38
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...