• Benedikt Meurer's avatar
    [debug] Make JSArrayBuffer (pre)views into internal properties. · 2cab7ae9
    Benedikt Meurer authored
    For JSArrayBuffer instances (which map to both v8::ArrayBuffer and
    v8::SharedArrayBuffer), we add a couple of synthetic views to its
    ValueMirror to make it easy for developers to peak into the contents of
    the JSArrayBuffer. These were previously real properties, but that's
    just wrong (both intuitively and semantically), and they should instead
    be internal properties.
    
    Drive-by-fix: The [[IsDetached]] internal property should only be shown
    on actually detached JSArrayBuffer's to reduce visual clutter. And for
    detached JSArrayBuffers creating views on them throws TypeErrors per
    specification, so we shouldn't attempt to display views on them.
    
    Bug: v8:9308, chromium:1162229
    Change-Id: Ia006de7873ca4b27aae7d00d46e1b69d2e326449
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606047
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71892}
    2cab7ae9
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...